all: more cleanups

Changes include:
  - extract headers.h from conf.h
  - use "byte" in some more places
  - unify "const" coding style
  - pefile.cpp: make sort order deterministic
  - simplify some other pefile.cpp code
  - CI updates

.github/CODEOWNERS

@@ -0,0 +1,11 @@
+*                               @markus-oberhumer @jreiser
+
+/src/p_elf*                     @jreiser
+/src/p_lx_*                     @jreiser
+/src/p_mach*                    @jreiser
+/src/p_unix*                    @jreiser
+/src/p_vmlin*                   @jreiser
+
+/src/stub/src/*bsd.*            @jreiser
+/src/stub/src/*darwin.*         @jreiser
+/src/stub/src/*linux.*          @jreiser

.github/typos_config.toml

@@ -9,6 +9,7 @@ extend-exclude = ["LICENSE"]
 [default.extend-identifiers]
 # misc variable names & symbols
 acc_spawnve = "acc_spawnve"
+ba = "ba"
 fo = "fo"
 fof = "fof"
 sidelen = "sidelen"

.github/workflows/ci.yml

@@ -377,8 +377,8 @@ jobs:
           - { zig_target: x86_64-macos.13-none }
           - { zig_target: x86_64-windows-gnu }
     env:
-      # 2023-03-14
-      ZIG_DIST_VERSION: 0.11.0-dev.1970+962299157
+      # 2023-03-18
+      ZIG_DIST_VERSION: 0.11.0-dev.2157+f56f3c582
       # for zig-cc wrapper scripts (see below):
       ZIG_CPPFLAGS: -DUPX_DOCTEST_CONFIG_MULTITHREADING
       ZIG_FLAGS: ${{ matrix.zig_flags }}

.github/workflows/minimal-ci.yml

@@ -5,22 +5,25 @@ name: 'CI - Minimal CI with Alpine Linux'
 on: [workflow_dispatch]
 jobs:
   job-alpine-cmake:
-    strategy: {matrix: {container: ['alpine:3.12','alpine:3.17','alpine:edge']}}
+    strategy:
+      fail-fast: false
+      matrix: {container: ['alpine:3.12','alpine:3.17','alpine:edge','i386/alpine:edge']}
     name: ${{ format('container {0}', matrix.container) }}
     runs-on: ubuntu-latest
     container: ${{ matrix.container }}
     steps:
       - name: ${{ format('Install packages {0}', matrix.container) }}
         run: 'apk update && apk upgrade && apk add bash clang cmake g++ git make'
-      - name: ${{ format('Check out code upx-{0}', github.ref_name) }}
+      - name: ${{ format('Check out UPX {0} source code', github.ref_name) }}
         run: |
           git clone --branch "$GITHUB_REF_NAME" --depth 1 https://github.com/upx/upx
           git -C upx submodule update --init
-          echo "artifact_name=upx-${GITHUB_REF_NAME}-${GITHUB_SHA:0:7}-minimal-ci-${{ matrix.container }}" | sed 's/[:,; ]/-/g' >> $GITHUB_ENV
+          echo "artifact_name=upx-${GITHUB_REF_NAME}-${GITHUB_SHA:0:7}-minimal-ci-${{ matrix.container }}" | sed 's/[^=0-9a-zA-Z_.-]/-/g' >> $GITHUB_ENV
       - { name: 'Build clang', run: 'make -C upx UPX_XTARGET=clang-static CC="clang -static" CXX="clang++ -static"' }
       - { name: 'Build gcc',   run: 'make -C upx UPX_XTARGET=gcc-static   CC="gcc -static"   CXX="g++ -static"' }
       - { name: 'Strip release binaries', run: 'strip -p --strip-unneeded upx/build/*/*/release/upx' }
       - name: ${{ format('Upload artifact {0}', env.artifact_name) }}
+        if: ${{ !startsWith(matrix.container, 'i386/alpine') }} # missing nodejs
         uses: actions/upload-artifact@v3
         with:
           name: ${{ env.artifact_name }}

.github/workflows/scan-build.yml

@@ -7,16 +7,20 @@ on:
 
 jobs:
   analyze:
-    name: Analyze
+    strategy:
+      fail-fast: false
+      matrix: {container: ['alpine:3.16','alpine:3.17','alpine:edge','i386/alpine:edge']}
+    name: ${{ format('Analyze {0}', matrix.container) }}
     runs-on: ubuntu-latest
-    container: 'alpine:edge'
+    container: ${{ matrix.container }}
     steps:
-      - name: 'Install packages'
+      - name: ${{ format('Install packages {0}', matrix.container) }}
         run: 'apk update && apk upgrade && apk add bash clang clang-analyzer cmake g++ git make'
-      - name: 'Check out code'
-        uses: actions/checkout@v3
-        with: { submodules: true }
+      - name: ${{ format('Check out UPX {0} source code', github.ref_name) }}
+        run: |
+          git clone --branch "$GITHUB_REF_NAME" --depth 1 https://github.com/upx/upx
+          git -C upx submodule update --init
       - name: 'Perform scan-build Analysis Debug'
-        run: 'make build/extra/scan-build/debug'
+        run: 'make -C upx build/extra/scan-build/debug'
       - name: 'Perform scan-build Analysis Release'
-        run: 'make build/extra/scan-build/release'
+        run: 'make -C upx build/extra/scan-build/release'